Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate revisional entity content is broken #4139

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@clemens-tolboom
Copy link
Contributor

commented Aug 22, 2019

This lack of ; was introduced in dd64922

@clemens-tolboom clemens-tolboom referenced this pull request Aug 22, 2019
10 of 10 tasks complete
@enzolutions

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

@clemens-tolboom this is ready to test?

@clemens-tolboom

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

@clemens-tolboom this is ready to test?

? ... we just need the semi-colon back right?

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

Sure, I just want to confirm, there is nothing else pending to commit, we will check and merge soon.

Thanks for your contributions.

@clemens-tolboom

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

Are there tests available (for checking generated code)? ... I'm just busy doning #4138 :-)

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

Sadly, we don't have support for that kind of tests :S

@clemens-tolboom

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

@enzolutions I tried to test through #3939 ... can you help with that?

@enzolutions

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

@enzolutions enzolutions merged commit e03be58 into hechoendrupal:master Sep 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
enzolutions added a commit that referenced this pull request Sep 6, 2019
Add bundle permissions for content entity (#4138)
* Add command option has-bundle-permissions and use on entity.

* Add (Entity}Permissions.php file.

* Add permission_callback to permissions.yml file.

* Added fix from #4139 as it hurts.

* Add own permissions checks.
mondrake added a commit to mondrake/drupal-console that referenced this pull request Sep 8, 2019
mondrake added a commit to mondrake/drupal-console that referenced this pull request Sep 8, 2019
Add bundle permissions for content entity (hechoendrupal#4138)
* Add command option has-bundle-permissions and use on entity.

* Add (Entity}Permissions.php file.

* Add permission_callback to permissions.yml file.

* Added fix from hechoendrupal#4139 as it hurts.

* Add own permissions checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.