Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 11.2 has quite the impact... somewhat negatively I'm afraid #115

Merged
merged 7 commits into from Nov 8, 2019

Conversation

@heckj
Copy link
Owner

heckj commented Nov 2, 2019

Updated the project to enable the workaround DEAD_CODE_STRIPPING=NO to handle the side effects of using Entwine as a testing library, which exposes bug https://bugs.swift.org/plugins/servlet/mobile#issue/SR-11564 (per tcldr/Entwine#14)

Also updating the tests so they pass, which shows that the Throttle operator no longer appears to respect latest=false, reported to Apple as FB7424221.

On the plus side, we've had several fixes and updates from Serhii Kyrylenko, so I'm including him into the About This Book section for his contributions.

heckj added 2 commits Nov 2, 2019
…mented out the Entwine tests - and there's a regular test change that may indicidate a slight difference in how throttle works
@heckj heckj force-pushed the xcode11.2_entwine branch from bbf8c67 to 6ea28e2 Nov 2, 2019
@heckj heckj changed the title Xcode 11.2 and Entwine are apparently not working well together - com… Xcode 11.2 has quite the impact... somewhat negatively I'm afraid Nov 2, 2019
@heckj heckj merged commit 7e7646a into master Nov 8, 2019
3 checks passed
3 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@heckj heckj deleted the xcode11.2_entwine branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.