Optimize performance of LowPassFilter#86
Merged
hecomi merged 1 commit intohecomi:mainfrom Jan 6, 2026
Merged
Conversation
Owner
|
Thank you for the excellent PR! I'll review it as soon as possible and get it merged. |
Owner
|
Sorry for the very late review, and thank you so much for the excellent pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While profiling my wasm port wLipSync, I noticed that the low pass filter was the most expensive by a large margin. Luckily, the performance can be improved drastically with some minor changes. After testing if these performance gains are also possible in uLipSync with the Burst compiler, I can confirm that they are! :-)
This PR optimizes the
LowPassFilterfunction by swapping the inner and outer loop and eliminating the if statement. The following table shows the performance improvement when measuring the entire algorithm (rough measurements):There is one further optimization possible. Since the next step will be downsampling, the low pass filter can be applied only to the samples that are a multiple of
skipin case ofDownSampleExact, as the other samples are ignored anyway. But this requires more work to get theskipvalue used inDownSamplebefore callingLowPassFilter. For reference, here's the commit implementing it: mrxz/wLipSync@5ded0c4