Bluebox: Add RHEL support #5

Merged
merged 3 commits into from Dec 28, 2012

Conversation

Projects
None yet
3 participants
@ChrisLundquist
Contributor

ChrisLundquist commented Dec 27, 2012

Tested on centos 6.3

hectcastro added a commit that referenced this pull request Dec 28, 2012

@hectcastro hectcastro merged commit 2c4de01 into hectcastro:master Dec 28, 2012

1 check passed

default The Travis build passed
Details
@ChrisLundquist

This comment has been minimized.

Show comment Hide comment
@ChrisLundquist

ChrisLundquist Dec 28, 2012

Contributor

thanks!

Contributor

ChrisLundquist commented Dec 28, 2012

thanks!

@hectcastro

This comment has been minimized.

Show comment Hide comment
@hectcastro

hectcastro Dec 28, 2012

Owner

No, thank you! I'm going to test this in my dev environment to make sure Ubuntu support doesn't break and then I'll cut a new version.

Owner

hectcastro commented Dec 28, 2012

No, thank you! I'm going to test this in my dev environment to make sure Ubuntu support doesn't break and then I'll cut a new version.

@ChrisLundquist

This comment has been minimized.

Show comment Hide comment
@ChrisLundquist

ChrisLundquist Dec 28, 2012

Contributor

sure thing, if there is a regression, let me know and I will add some tests.

Contributor

ChrisLundquist commented Dec 28, 2012

sure thing, if there is a regression, let me know and I will add some tests.

@ChrisLundquist

This comment has been minimized.

Show comment Hide comment
@ChrisLundquist

ChrisLundquist Dec 28, 2012

Contributor

FWIW, my uber lame tests are here.

#!/usr/bin/env bats

@test "statsd should be installed" {
    [ -d /usr/share/statsd/ ]
}

@test "statsd should start on boot" {
    [ "$(chkconfig --list statsd | grep '3:on')" ]
}

I would love to find a cross platform way to check start on boot

Contributor

ChrisLundquist commented Dec 28, 2012

FWIW, my uber lame tests are here.

#!/usr/bin/env bats

@test "statsd should be installed" {
    [ -d /usr/share/statsd/ ]
}

@test "statsd should start on boot" {
    [ "$(chkconfig --list statsd | grep '3:on')" ]
}

I would love to find a cross platform way to check start on boot

@hectcastro

This comment has been minimized.

Show comment Hide comment
@hectcastro

hectcastro Dec 28, 2012

Owner

I believe test-kitchen takes care of this along with minitest-handler tests, but I haven't gotten to adding support for these cookbooks yet.

Owner

hectcastro commented Dec 28, 2012

I believe test-kitchen takes care of this along with minitest-handler tests, but I haven't gotten to adding support for these cookbooks yet.

@ChrisLundquist

This comment has been minimized.

Show comment Hide comment
@ChrisLundquist

ChrisLundquist Dec 28, 2012

Contributor

I was dissatisfied with test-kitchen because:

  • it is tied to the vagrant gem (which mitchellh is deprecating),
  • has odd paths ( I think your tests will get synced by chef-server, could be mistaken or ignored now ),
  • and installs things for you behind the scenes ( this doesn't reflect my production environment ).
  • prints lots of crap

Maybe it has improved and I'll give it another go.

Contributor

ChrisLundquist commented Dec 28, 2012

I was dissatisfied with test-kitchen because:

  • it is tied to the vagrant gem (which mitchellh is deprecating),
  • has odd paths ( I think your tests will get synced by chef-server, could be mistaken or ignored now ),
  • and installs things for you behind the scenes ( this doesn't reflect my production environment ).
  • prints lots of crap

Maybe it has improved and I'll give it another go.

@nelsonjchen

This comment has been minimized.

Show comment Hide comment
@nelsonjchen

nelsonjchen Jan 26, 2013

Contributor

Can you have a comma at the end of the line here in Ruby? The cookbook fails for me around here.

Contributor

nelsonjchen commented on recipes/default.rb in fc9721a Jan 26, 2013

Can you have a comma at the end of the line here in Ruby? The cookbook fails for me around here.

This comment has been minimized.

Show comment Hide comment
@ChrisLundquist

ChrisLundquist Jan 26, 2013

Contributor

Ruby doesn't usually care about dangling comas

irb(main):001:0> [1,2,3,]
=> [1, 2, 3]
irb(main):002:0> { :foo => 1, :bar =>2, }
=> {:foo=>1, :bar=>2}

It might be because the hash is implicit.

does wrapping it in { } fix it?

Contributor

ChrisLundquist replied Jan 26, 2013

Ruby doesn't usually care about dangling comas

irb(main):001:0> [1,2,3,]
=> [1, 2, 3]
irb(main):002:0> { :foo => 1, :bar =>2, }
=> {:foo=>1, :bar=>2}

It might be because the hash is implicit.

does wrapping it in { } fix it?

fredrick pushed a commit to Dwolla/chef-statsd that referenced this pull request Jul 21, 2014

Merge pull request #5 from lewg/graph-templates
Graph templates configuration support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment