Uncaught Error In CassandraHostRetryService.verifyConnection Can Kill RetryRunner #423

Closed
cherron opened this Issue Feb 17, 2012 · 1 comment

Projects

None yet

2 participants

@cherron
cherron commented Feb 17, 2012

There is a non-zero chance of a java.lang.Error stopping subsequent executions of the RetryRunner task.
CassandraHostRetryService.verifyConnection should catch and log Throwable instead of Exception. Also, it would be nice if that log message included the affected host.

@cherron
cherron commented Feb 23, 2012

In the end, the error turned out not to be originating in verifyConnection, however verifyConnection should probably still catch Throwable instead of Exception in order to be able to not interrupt checks for other hosts.

Pull request to follow...

@cherron cherron pushed a commit to cherron/hector that referenced this issue Feb 23, 2012
Chris Herron RetryRunner Dies If ThriftCluster Was Not Created Via HFactory. Fixes…
… issues #423 and #424.
c156654
@cherron cherron pushed a commit to cherron/hector that referenced this issue Feb 29, 2012
Chris Herron RetryRunner Dies If ThriftCluster Was Not Created Via HFactory. Fixes…
… issues #423 and #424.
903ab5e
@patricioe patricioe closed this Feb 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment