RetryRunner Dies If ThriftCluster Was Not Created Via HFactory #424

Closed
cherron opened this Issue Feb 23, 2012 · 0 comments

2 participants

@cherron

RetryRunner's checkRing/buildRingInfo optimization assumes that a named ThriftCluster can be obtained via HFactory.getCluster. ThriftCluster is not exclusively created & cached by HFactory. E.g. Some users instantiate directly via Spring.

This is related to issue #423. In this scenario, a NullPointerException causes the RetryRunner executor to stop, so no more reconnect attempts are made.

Pull request on the way after testing...

@cherron cherron pushed a commit to cherron/hector that referenced this issue Feb 23, 2012
Chris Herron RetryRunner Dies If ThriftCluster Was Not Created Via HFactory. Fixes…
… issues #423 and #424.
c156654
@cherron cherron pushed a commit to cherron/hector that referenced this issue Feb 29, 2012
Chris Herron RetryRunner Dies If ThriftCluster Was Not Created Via HFactory. Fixes…
… issues #423 and #424.
903ab5e
@patricioe patricioe closed this Feb 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment