Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify HOpTimer to support different lifecycle monitors #515

Merged
merged 9 commits into from Mar 2, 2013

Conversation

ezbz
Copy link
Contributor

@ezbz ezbz commented Sep 2, 2012

Add tagName parameter to the start method to support other monitor lifecycle patterns such as the one mandated by Metrics (http://metrics.codahale.com/).

@patricioe
Copy link
Collaborator

+1 for coda hale.

Should we make the time unit in millis rather than nanos? Nanoseconds is
best where you are timing local computations.
On Sep 2, 2012 5:15 AM, "Erez Mazor" notifications@github.com wrote:

Add tagName parameter to the start method to support other monitor
lifecycle patterns such as the one mandated by Metrics (

http://metrics.codahale.com/).

You can merge this Pull Request by running:

git pull https://github.com/erezmazor/hector master

Or view, comment on, or merge it at:

#515
Commit Summary

File Changes

  • M core/pom.xml (4)
  • _M_core/src/main/java/me/prettyprint/cassandra/connection/HConnectionManager.java
    (2)
  • _M_core/src/main/java/me/prettyprint/cassandra/connection/HOpTimer.java (2)
  • _A_core/src/main/java/me/prettyprint/cassandra/connection/MetricsOpTimer.java
    (46)
  • _M_core/src/main/java/me/prettyprint/cassandra/connection/NullOpTimer.java (2)
  • _M_core/src/main/java/me/prettyprint/cassandra/connection/SpeedForJOpTimer.java
    (2)
  • M pom.xml (5)

Patch Links

@ezbz
Copy link
Contributor Author

ezbz commented Mar 2, 2013

Rebased with current master and added example test showing basic usage with MetricsRegistry

@zznate
Copy link
Collaborator

zznate commented Mar 2, 2013

Nice! Thanks.

zznate added a commit that referenced this pull request Mar 2, 2013
Modify HOpTimer to support different lifecycle monitors
@zznate zznate merged commit 21ac921 into hector-client:master Mar 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants