Add other constructors for StringKeyIterator #573

Merged
merged 1 commit into from Dec 27, 2012

3 participants

@senthilkumar-kj

Most times, keys are strings and I find myself using StringKeyIterator to go through all keys (or list keys). And to have control over maxRowCount fetched at a time, I have to use KeyIterator. Having other constructors in StringKeyIterator makes the job easier as the whole purpose of StringKeyIterator is to have an easy-readable alternative.

UPDATE: As suggested by Nate, refactored KeyIterator constructor to builder pattern.

Thanks,

@skaruppiah skaruppiah Refactor KeyIterator constructor to builder pattern
and mark the constructors as deprecated and leave it for back for backward compatability
b21dcb7
@senthilkumar-kj

Nate, my bad, didn't think of backward compatibility. As you suggested, I put the constructors back and marked them as @Deprecated.

Thanks,

@zznate
Collaborator

Awesome! Thanks.

@zznate zznate merged commit 684cda8 into hector-client:master Dec 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment