issue #594, handle SocketTimeoutException differently #608

Merged
merged 2 commits into from Mar 28, 2013

Conversation

Projects
None yet
2 participants

It consists of two changes:

  • HThriftClient, generates HectorException in getCassandra
  • Revert back the change for #434. I have tested the different scenario by shutting down Cassandra or make it responds really slow. I can't observe the problem described in #434. By coverting SocketTimeoutException to HTimedOutException, it avoids shutting down the pool when socket timed out.

The code has been in our production for over 2 weeks and everything works as expected.

Collaborator

zznate commented Mar 28, 2013

This looks good - thanks!

zznate merged commit d862e95 into hector-client:master Mar 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment