Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GA and Disqus in default CSP #1375

Merged
merged 4 commits into from Jun 8, 2021

Conversation

davidmehren
Copy link
Member

Component/Part

Config/config defaults

Description

This PR disables Google Analytics and Disqus in our default CSP and updates the documentation accordingly.

I'm open to suggestions for other wording in the release notes and config option descriptions :)

Steps

  • Added implementation
  • Added / updated documentation
  • I read the contribution documentation and
    made sure that:
    • My commits are signed-off to accept the DCO.
    • This PR targets the correct branch: master for 1.x & docs, develop for 2.x

Related Issue(s)

@davidmehren davidmehren added type: feature enhancement An improvement to existing functionality security Concerning the security of HedgeDoc labels Jun 7, 2021
@davidmehren davidmehren added this to the Release 1.9 milestone Jun 7, 2021
@davidmehren davidmehren self-assigned this Jun 7, 2021
Signed-off-by: David Mehren <git@herrmehren.de>
Signed-off-by: David Mehren <git@herrmehren.de>
Signed-off-by: David Mehren <git@herrmehren.de>
Signed-off-by: David Mehren <git@herrmehren.de>
@davidmehren davidmehren force-pushed the feature/yeet_google_analytics branch from cbe9fab to 5e771c2 Compare June 7, 2021 20:57
@davidmehren davidmehren merged commit 960f5c1 into master Jun 8, 2021
13 checks passed
@davidmehren davidmehren deleted the feature/yeet_google_analytics branch June 8, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Concerning the security of HedgeDoc type: feature enhancement An improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants