fix(image-upload): Fix swallowing of errors for filesystem - #1544
Merged
Merged
Conversation
This patch fixes the swollowing of the actual error message that appears when a file fails to move, after being uploaded to Hedgedoc on an instance that is using the upload-method `filesystem` active. This became apparent when the error messages provided by some users, where less than helpful. As a solution the error message of the copy command was added to the error that is output to the console. https://community.hedgedoc.org/t/image-upload-fail-docker/439 Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
davidmehren
approved these changes
Aug 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component/Part
image-upload/filesystem
Description
This patch fixes the swallowing of the actual error message that appears
when a file fails to move, after being uploaded to Hedgedoc on an
instance that is using the upload-method
filesystemactive.This became apparent when the error messages provided by some users,
where less than helpful.
As a solution the error message of the copy command was added to the
error that is output to the console.
Steps
made sure that:
masterfor 1.x & docs,developfor 2.xRelated Issue(s)
https://community.hedgedoc.org/t/image-upload-fail-docker/439