From 5fe63e57925d54ca6e70383a2be04943c7120cd8 Mon Sep 17 00:00:00 2001 From: Tilman Vatteroth Date: Mon, 8 Feb 2021 15:11:27 +0100 Subject: [PATCH 1/2] Readd legacy pdf short code markdown it plugin Signed-off-by: Tilman Vatteroth --- .../markdown-it-configurator/FullMarkdownItConfigurator.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/components/markdown-renderer/markdown-it-configurator/FullMarkdownItConfigurator.tsx b/src/components/markdown-renderer/markdown-it-configurator/FullMarkdownItConfigurator.tsx index 1e45cc9d9e..bb9e3b9e49 100644 --- a/src/components/markdown-renderer/markdown-it-configurator/FullMarkdownItConfigurator.tsx +++ b/src/components/markdown-renderer/markdown-it-configurator/FullMarkdownItConfigurator.tsx @@ -22,6 +22,7 @@ import { LineMarkers, lineNumberMarker } from '../replace-components/linemarker/ import { VimeoReplacer } from '../replace-components/vimeo/vimeo-replacer' import { YoutubeReplacer } from '../replace-components/youtube/youtube-replacer' import { BasicMarkdownItConfigurator } from './BasicMarkdownItConfigurator' +import { legacyPdfShortCode } from '../regex-plugins/replace-legacy-pdf-short-code' export class FullMarkdownItConfigurator extends BasicMarkdownItConfigurator { constructor( @@ -53,6 +54,7 @@ export class FullMarkdownItConfigurator extends BasicMarkdownItConfigurator { YoutubeReplacer.markdownItPlugin, VimeoReplacer.markdownItPlugin, GistReplacer.markdownItPlugin, + legacyPdfShortCode, legacySlideshareShortCode, legacySpeakerdeckShortCode, AsciinemaReplacer.markdownItPlugin, From 6f8b30ad93a72b55a870dc3203cc09a23862ec7b Mon Sep 17 00:00:00 2001 From: Tilman Vatteroth Date: Mon, 8 Feb 2021 15:22:16 +0100 Subject: [PATCH 2/2] Add shortcode e2e test Signed-off-by: Tilman Vatteroth --- cypress/integration/shortcodes.spec.ts | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 cypress/integration/shortcodes.spec.ts diff --git a/cypress/integration/shortcodes.spec.ts b/cypress/integration/shortcodes.spec.ts new file mode 100644 index 0000000000..8a9e31a5e1 --- /dev/null +++ b/cypress/integration/shortcodes.spec.ts @@ -0,0 +1,20 @@ +/* + * SPDX-FileCopyrightText: 2021 The HedgeDoc developers (see AUTHORS file) + * + * SPDX-License-Identifier: AGPL-3.0-only + */ + +describe('Short code', () => { + beforeEach(() => { + cy.visitTestEditor() + }) + + describe('for pdfs', () => { + it('renders a plain link', () => { + cy.codemirrorFill(`{%pdf https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf %}`) + cy.getMarkdownBody() + .find('a') + .should('have.attr', 'href', 'https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf') + }) + }) +})