Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add classifications to properties #253
Lol, yes sorry - I wanted to fix the 8.2.1 issue before cleaning it up. I'll add the WIP tag…
On Sun, 17 Mar 2019 at 20:35, Nikos Baxevanis ***@***.***> wrote: Thanks for sending a pull request
Mar 17, 2019
jacobstanley left a comment •
Sorry for all the style nitpicks, I should really have a style guide. I didn't comment on all the abbreviations but you please find / fix them all. The codebase is pristine at the moment and I want to keep it that way. Generally this looks pretty good though, would love to have this feature!
Fwiw I'm happy to make the style fixups myself in another PR if you can't be bothered.
jacobstanley left a comment
Just a few items, would also like to make sure @HuwCampbell is happy enough with this before going ahead. I would like to align this with the approach taken in #262, but I don't think we need to hold this PR up because of that. All those changes wouldn't affect the public API so I don't mind if we do it over time.
Great, so I started adding a few newtypes around
It also prints the current coverage while the test is running, you'll need to run the example to see. I moved the test to