Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define proper Applicative instances for Node, Tree and GenT #269

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
2 participants
@jystic
Copy link
Member

jystic commented Apr 14, 2019

Made the necessary changes to #173 so that I was happy to merge.

Not sure about the name hedgehog-test-laws as the main point is that it depends on QuickCheck but we can always change it later as it's never published anywhere.

The idea would be to switch to using Hedgehog itself when we have some way to verify laws, which requires that we can generate functions.

sjakobi and others added some commits Mar 17, 2018

Define proper Applicative instances for Node, Tree and GenT
* Also canonicalize a few Monad instances.

* Also add Eq instances for Tree and Node.

* As GenT's Monad and Applicative instances aren't lawful the associated
  tests are marked as ignored.

* The testsuite is unbuildable with GHC < 8.0 as a few required
   Show1/Show instances are only defined for base >= 4.9.

@jystic jystic force-pushed the jystic:topic/applicative branch from ecdaacc to 5fdcf45 Apr 14, 2019

@jystic jystic force-pushed the jystic:topic/applicative branch from 5fdcf45 to 32b33c9 Apr 14, 2019

@jystic

This comment has been minimized.

Copy link
Member Author

jystic commented Apr 14, 2019

This PR isn't required, I learned how to update the original PR with my changes.

@jystic jystic closed this Apr 14, 2019

@jystic jystic deleted the jystic:topic/applicative branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.