Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonadGen instances for StateT #330

Merged

Conversation

symbiont-sam-halliday
Copy link
Contributor

Assuming the instances work as expected, this should fix #287

I'm fairly sure this is all possible thanks to #321 by @HuwCampbell.

Copy link
Member

@jacobstanley jacobstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 hooray

@jacobstanley jacobstanley merged commit 87fb70e into hedgehogqa:master Oct 10, 2019
@sshine
Copy link
Contributor

sshine commented Oct 10, 2019

You're a hero, @symbiont-sam-halliday!

@symbiont-sam-halliday
Copy link
Contributor Author

@jacobstanley could you please release a 1.0.2 with this fix in it? 😄 ... it makes everything so much nicer!

Thanks @sshine but the real hero is @HuwCampbell

@symbiont-sam-halliday
Copy link
Contributor Author

symbiont-sam-halliday commented Oct 23, 2019

BTW although this is compiling I am seeing some very strange behaviour... it looks like shrunk tests can see state that was created in the unshrunk tests. I had assumed that everything would be correctly isolated but that is not true. i.e. the state is preserved when the test fails and is not wound back. This makes me suspicious of all "effectful generators". I'll create a ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stateful generation
3 participants