Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Publish Extension on open-vsx.org for VSCodium users #110

Closed
ChrisCrossQS opened this issue Jul 3, 2020 · 16 comments
Closed

Request: Publish Extension on open-vsx.org for VSCodium users #110

ChrisCrossQS opened this issue Jul 3, 2020 · 16 comments
Labels
enhancement New feature or request I probably won't do it soon will do for sponsorship I do this project just for fun. You can support me at https://github.com/sponsors/hediet ;)
Projects

Comments

@ChrisCrossQS
Copy link

ChrisCrossQS commented Jul 3, 2020

Hi Hediet,

currently the extension is available on the Microsoft VS Code marketplace.
VS Codium (VS Code without MS telemetry, link for more details: https://github.com/VSCodium/vscodium/blob/master/DOCS.md)
uses the open-vsx.org marketplace (Eclipse Foundation) instead. This has an adapter for MS VS Code Marketplace, but currently your extension is not available in VS Codium using open-vsx. Would it be possible for you, to post the extension also to open-vsx.org? Alternatively the extension could be added here: https://github.com/open-vsx/publish-extensions. They would then publish it in a nightly run.

Thanks for your feedback
Chris

@hediet hediet added this to Triage in Backlog Jul 3, 2020
@hediet
Copy link
Owner

hediet commented Jul 20, 2020

I will consider this if this issue gets 10 upvotes!
Also, telemetry is a good thing... Especially when you have to triage a lot because the work power does not cover the feature demand, telemetry helps to prioritize the important things.

@hediet hediet moved this from Triage to Awaiting Feedback in Backlog Jul 20, 2020
@hediet hediet added enhancement New feature or request I probably won't do it soon will do for sponsorship I do this project just for fun. You can support me at https://github.com/sponsors/hediet ;) labels Jul 23, 2020
@HansUXdev
Copy link

I'm trying to do this right now for the auth0 hackathon.
@hediet I love the "will do for sponsorship".

I feel that for sure. I'm trying to use GitPod for educational modules and would love this extension forked over so people can communicate and collaborate visually on things.

@hediet
Copy link
Owner

hediet commented Aug 9, 2020

Thanks ;) Why do you need this extension to be forked? How does open-vsx relate to git pod?
What are you trying to do? ;)

@HansUXdev
Copy link

HansUXdev commented Aug 9, 2020

So to my understanding, GitPod is built on top of theia ide and uses open-vsx because due to the pseudo-open-source nature of the vscode marketplace, they can't add them from marketplace.

The challenge for the hackathon is to improve connectivity because coworkers, etc and so having draw.io on the here would allow me to communicate with designers in a shared remote environment about design decisions and architecture.

Here is the hackathon repo: https://github.com/HansUXdev/RemoteDevCatz
There are more than a few images made by draw.io
But I can't view them in the ide unless I export them.

I'm not trying to promote that by the way. But I'm super excited because GitPod gave me the ability to students with inadequate hardware and draw.io would let me teach front-end really easy...

@hediet
Copy link
Owner

hediet commented Aug 10, 2020

Sadly, Theia does not seem to support custom editors yet. So this extension is not compatible with theia anyways! Publishing to open-vsx does not help here.

@HansUXdev
Copy link

@hediet I think this can be closed, I managed to publish it on the open-vsx. Took me a while to figure out how to compile it. I had to install bufferutil & utf-8-validate, run the pre-build than the build than I just ran ovsx create-namespace hediet and ovsx publish.

Also @ChrisCrossQS I just tested it on codium and it works like a charm!
It doesn't work in gitPod for some reason I have yet to figure out.
It throws the following error: Integration failed: o.window.registerCustomEditorProvider is not a function.

@hediet
Copy link
Owner

hediet commented Aug 31, 2020

@HansUXdev thanks ;)
BTW this is what I meant with

Sadly, Theia does not seem to support custom editors yet. So this extension is not compatible with theia anyways

@hediet
Copy link
Owner

hediet commented Aug 31, 2020

Also, compiling should not be difficult. There is a github action that builds every commit for each platform, ensuring that everything builds properly!

@hediet
Copy link
Owner

hediet commented Sep 4, 2020

I managed to publish it on the open-vsx. T

Argh, you didn't use the same workflow as I do for preparing the extension... You published the dev-build with version 999! This will stay the newest version forever. Please delete the version and have a look at the github actions on how to publish it. Alternatively, you can open a PR and change the github action to publish it automatically to open vsx.

@HansUXdev
Copy link

This was the first extension I've worked with so my bad 😓 .
Since then I've publish a few other smaller ones.

I'll sort this out, however to be fair the culprit is the package.json because I didn't check the package version.

"version": "999.0.0-alpha",

@HansUXdev
Copy link

It's been unpublished now. I need to figure out how to use github actions to build it correctly.
I also need to figure out how to run your other extension to visualize algorithms.

@hediet
Copy link
Owner

hediet commented Sep 7, 2020

Thanks! Have a look at the publish github action. It runs a script first that uses the version from the changelog. The package json version is that high so that when debugging it, it always overrides any installed version.

@MarcusLlewellyn
Copy link

It appears that @HansUXdev may have unlisted rather than removed his build of this extension on open-vsx. I'm using the Draw.io extension with code-server, and when I attempt to install the VSIX myself, it keeps trying to update it to version 999.0.0-alpha.

@HansUXdev
Copy link

@MarcusLlewellyn I'm not sure why that is happening. Did you download it before all this?

Also to clarify, I don't think you can directly unlist or unpublished it on open-vsx. I had to ask the maintainers directly on gitter. @hediet may need to request direct access to the namespace.

I haven't had the need or interest in learning how to use github actions and honestly I don't think that will change so, if gitpod adds support for custom methods, I may end up republishing a forked version under a different namespace with package.json set to 1.0.0 and manually pull/maintain the open-vsx version.

But other than that, I'm going hands off on this because I need to focus on a few other projects.

@hediet hediet moved this from Awaiting Feedback to Will Do in Backlog Oct 11, 2020
@nopeslide
Copy link

@hediet
it doesn't look like you claimed your open-vsx namespace.
if you don't want others to publish under your name, I recommend claiming it.
this works by opening an issue in their repository: open issue.
publishing is very similar to the ms marketplace

@hediet
Copy link
Owner

hediet commented Nov 8, 2020

This is a blocker.

@hediet hediet moved this from Will Do to In Progress in Backlog Nov 8, 2020
@hediet hediet closed this as completed in b85cca5 Nov 8, 2020
@hediet hediet moved this from In Progress to Released To Insiders in Backlog Nov 8, 2020
@hediet hediet moved this from Released To Insiders to Released in Backlog Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request I probably won't do it soon will do for sponsorship I do this project just for fun. You can support me at https://github.com/sponsors/hediet ;)
Projects
Backlog
  
Released
Development

No branches or pull requests

5 participants