New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I am a naughty commit! #3

Merged
merged 2 commits into from Jan 16, 2017

Conversation

Projects
None yet
1 participant
@hedss
Copy link
Owner

hedss commented Jan 12, 2017

I have no change type!

I am a naughty commit!
I have no change type!
@hedss

This comment has been minimized.

Copy link
Owner

hedss commented Jan 13, 2017

I'm a strange comment.

@hedss
Copy link
Owner

hedss left a comment

This is a comment on something.

@hedss

This comment has been minimized.

Copy link
Owner

hedss commented Jan 13, 2017

Final comment.

@ghost
Copy link

ghost left a comment

I am a different reviewer.

@ghost

This comment has been minimized.

Copy link

ghost commented Jan 13, 2017

And I am a different comment.

@@ -1 +1,2 @@
console.log('Does nothing');

This comment has been minimized.

@ghost

ghost Jan 13, 2017

A different type of review.

dummy.js Outdated
@@ -1 +1,2 @@
console.log('Does nothing');
console.log('Now with added bad commit message');

This comment has been minimized.

@ghost

ghost Jan 13, 2017

Oh dear, it seems only certain review types are shown!

@ghost
Copy link

ghost left a comment

General

@@ -1 +1,2 @@
console.log('Does nothing');

This comment has been minimized.

@ghost

ghost Jan 13, 2017

General review comment.

@ghost
Copy link

ghost left a comment

A generic comment not referencing the code.

@ghost
Copy link

ghost left a comment

Some changes, please.

dummy.js Outdated
@@ -1 +1,2 @@
console.log('Does nothing');
console.log('Now with added bad commit message');

This comment has been minimized.

@ghost

ghost Jan 13, 2017

Some other changes, please.

And now a decent change type..
Change-Type: patch

@hedss hedss merged commit e878637 into master Jan 16, 2017

1 check passed

versionist Valid `Change-Type` versionist tag in PR.

@hedss hedss deleted the bad-branch branch Jan 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment