Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed-position elements, CoffeeScript 2.2.0 #17

Open
wants to merge 3 commits into
base: master
from

Conversation

@caleon
Copy link

caleon commented Apr 9, 2013

Various changes lifted from a project override to the fork:

  • Specified dependency requirement versions
  • Introduced data-intro-position to avoid clashes with other libraries' usage of the data attribute
  • When $.fn.chardinJs is called, it also adds the class "chardinated" to that element
  • Used the chardinated wrapper class to define a general style for dealing with existing fixed-position elements:
    • Without this change, fixed items remain un sync'ed with the overlay help items
    • Applies to items with class name including "-fixed", as in the Bootstrap case "navbar-fixed-top"
  • Used that same class distinction to temporarily adjust those fixed wrappers' z-index
    • If the item had a custom z-index and was fixed, it would not get displayed above the overlay even if it was intended to
    • These things get reset to their originals simply by the removal of the "chardinated" class on the "chardinJs:stop" event
  • Chardin help text text-aligned as befits the requested position of the help text:
    • Default => text-align: center
    • data-position: left => text-align: right
    • data-position: right => text-align: left
  • Recompiled assets with upgraded CoffeeScript 2.2.0, which most overtly removes the intial byline
caleon added 3 commits Apr 9, 2013
…e` task revised to use CoffeeScript.compile.
 * Introduced data-intro-position to avoid clashes with other libraries' usage of the data attribute
 * When $.fn.chardinJs is called, it also adds the class "chardinated" to that element
 * Used the chardinated wrapper class to define a general style for dealing with existing fixed-position elements:
    * Without this change, fixed items remain un sync'ed with the overlay help items
    * Applies to items with class name including "-fixed", as in the Bootstrap case "navbar-fixed-top"
 * Used that same class distinction to temporarily adjust those fixed wrappers' z-index
    * If the item had a custom z-index and was fixed, it would not get displayed above the overlay even if it was intended to
    * These things get reset to their originals simply by the remval of the "chardinated" class on the "chardinJs:stop" event
 * Chardin help text text-aligned as befits the requested position of the help text:
    * Default => text-align: center
    * data-position: left => text-align: right
    * data-position: right => text-align: left
 * Recompiled assets with upgraded CoffeeScript 2.2.0, which most notably removes the intial byline
@ericuldall

This comment has been minimized.

Copy link

ericuldall commented on 9626648 Nov 5, 2013

Updated my local version with chardinjs.css changes and chardinjs.min.js changes and they successfully fixed the fixed elements issue. Thanks for the commit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.