fix: diagnose update path conflicts#1
Open
hehanlin1996 wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Aiden
71ead71 to
ff48020
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve
lark-cli updatediagnostics for install/update instability reported around multiple installation paths and post-update binary verification failures.Changes
lark-cliexecutables and surface apath_conflictblock in JSON output plus a human-readable warning inupdate --check, manual-update, update-success, and verification-failure paths.lark-cli --version, clear shell command cache, and inspect duplicate installs.Test Plan
go test ./cmd/update -run 'TestUpdateCheck_(HumanWarnsOnMultiplePathCandidates|JSONIncludesPathConflict)$' -count=1(red before implementation, green after)go test ./cmd/update -run 'TestVerificationFailureHintExplainsStaleNpmPath|TestUpdateNpmVerifyFail_JSON_NoRestoreHintWhenBackupUnavailable|TestUpdateCheck_(HumanWarnsOnMultiplePathCandidates|JSONIncludesPathConflict)$' -count=1go test -race -count=1 ./cmd/update ./internal/selfupdatego vet ./cmd/update ./internal/selfupdategit diff --checkgo run . update --helpmake unit-testcurrently fails in unrelatedshortcuts/baseMIME expectation:large-report.binresolves toapplication/x-sega-cd-rominstead of expectedapplication/octet-streamon this runner.Related Issues
BASE-20260515-037,BASE-20260515-058)