fix: clarify IM message dry-run limits#3
Open
hehanlin1996 wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Aiden
19baad1 to
1286237
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies two IM shortcut UX gaps from the P1 IM/Agent collaboration evidence:
im +messages-send --dry-runnow explicitly warns that chat membership is not verified, and IM media flags now document the cwd-relative local path restriction.Changes
_notice.im_chat_membershipwarning forim +messages-send --chat-id --dry-run, while leaving direct--user-idsends unchanged.+messages-sendand+messages-replymedia flag help to say local file paths must be cwd-relative and absolute paths are rejected.Test Plan
go test ./shortcuts/im -count=1go test -race -gcflags="all=-N -l" ./shortcuts/im -count=1go build -buildvcs=false -o lark-cli . && LARK_CLI_BIN=$PWD/lark-cli go test ./tests/cli_e2e/im -run 'TestIM_MessagesSend(DryRunWarnsChatMembershipNotVerified|HelpDocumentsMediaPathRestriction)' -count=1 -vgofmt -l shortcuts/im tests/cli_e2e/im/messages_send_dryrun_test.goproduced no outputgo vet ./shortcuts/im ./tests/cli_e2e/imgo mod tidymade no changesmake unit-testattempted; unrelated existing failure inshortcuts/base(TestBaseRecordExecuteReadCreateDelete/upload_attachment_uses_multipart_for_large_file, MIME detected asapplication/x-sega-cd-romforlarge-report.bin). IM package passed in the same run.Related Issues
--image/--fileflags reject absolute paths but--helpdoesn't document this larksuite/cli#872