fix(base): default form attachment questions to all files#9
Open
hehanlin1996 wants to merge 1 commit into
Open
fix(base): default form attachment questions to all files#9hehanlin1996 wants to merge 1 commit into
hehanlin1996 wants to merge 1 commit into
Conversation
Co-Authored-By: Aiden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes larksuiteGH-929 feedback C6 for
base +form-questions-createattachment questions. Bare attachment questions now sendattachment.file_types: ["all"]so forms accept PDFs, Word documents, and other files like the UI does, while explicitattachmentorattachment_configinput is preserved.Changes
attachment.file_types: ["all"]when no attachment config is provided.--questionsflag help.Test Plan
go test ./shortcuts/base -run 'TestBaseFormQuestions' -count=1LARK_CLI_BIN=/tmp/lark-cli-feedback-fix-2026-05-17/lark-cli-base-form-attachment go test ./tests/cli_e2e/base -run TestBaseFormQuestionsCreateDryRun_AttachmentDefaultsAllFiles -count=1gofmt -l shortcuts/base/base_form_questions_create.go shortcuts/base/base_form_execute_test.go tests/cli_e2e/base/base_form_questions_dryrun_test.goproduced no outputgo test ./shortcuts/base -run 'TestBaseFormQuestionsExecuteCreate/attachment_defaults_to_all_file_types' -count=1failed before the fixRelated Issues