Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

A few minor issues #6

Closed
wants to merge 8 commits into from
+58,627 −105,372

2 participants

@Carpetsmoker

A few minor issues I ran into when implementing Org_Heigl_Hyphenator

  • Fix Dutch hyphenation file
  • Change Dutch country code to "nl", "ne" is extremely obscure and I've never seen it used.
  • Add current username to tmp path. This prevents problems with multiple users executing the Hyphenator
  • Throw exception when opening the parsedFile fails
  • Fix example in the README file
mtournoij and others added some commits
mtournoij Fix Dutch hyphenation file
Change Dutch country code to "nl", "ne" is extremly obscure and I've never
seen it used.
c095a20
mtournoij Add current username to tmp path
This prevents problems with multiple users executing the Hyphenator
1628c7e
mtournoij Throw exception when opening the parsedFile fails
Fix example in the README file
9f317cb
@Carpetsmoker Carpetsmoker Split words on any whitespace, not just space f9cecb8
@Carpetsmoker

One more addition: Words are split only on the space character

One area where this caused problems is if you end the line with a newline, and then start at the first position on the next. For example

Hello
World

Hello and World are treated as one word, and hyphenated as such. Sometimes leading to incorrectly placed hyphen characters.

Carpetsmoker added some commits
@Carpetsmoker Carpetsmoker List of changes:
- Fix languages that didn't work
- Remove duplicate language files
- Add new parameter for Ord_Heighl_Hyphenator->hyphenate: $html
  This allows "smart" detection of HTML tags and avoid hyphenating them
efd0eec
@Carpetsmoker Carpetsmoker This commit completes the previous one
Forgot to use "add" :-/
32a95fd
@Carpetsmoker Carpetsmoker Skip HTML entities, some other improvements e37c160
@Carpetsmoker Carpetsmoker Fix function comment 2f2b81d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 7, 2011
  1. Fix Dutch hyphenation file

    mtournoij authored
    Change Dutch country code to "nl", "ne" is extremly obscure and I've never
    seen it used.
  2. Add current username to tmp path

    mtournoij authored
    This prevents problems with multiple users executing the Hyphenator
  3. Throw exception when opening the parsedFile fails

    mtournoij authored
    Fix example in the README file
Commits on Sep 9, 2011
  1. @Carpetsmoker
Commits on Sep 12, 2011
  1. @Carpetsmoker

    List of changes:

    Carpetsmoker authored
    - Fix languages that didn't work
    - Remove duplicate language files
    - Add new parameter for Ord_Heighl_Hyphenator->hyphenate: $html
      This allows "smart" detection of HTML tags and avoid hyphenating them
  2. @Carpetsmoker

    This commit completes the previous one

    Carpetsmoker authored
    Forgot to use "add" :-/
  3. @Carpetsmoker
  4. @Carpetsmoker

    Fix function comment

    Carpetsmoker authored
Something went wrong with that request. Please try again.