Problem with groupFilter #9

Merged
merged 1 commit into from Mar 30, 2012

Projects

None yet

3 participants

@BlackSmith

Reair a problem with groupFilter.

@heiglandreas heiglandreas merged commit 2fa1264 into heiglandreas:master Mar 30, 2012
@heiglandreas

Thanks!

@brammeleman

Hi Andreas,
This fix isn't in the wordpress hosted zip download of the plugin.
Any plans to update?

Bests,

Bram

(i'm working on some patches)

I'm currently in the process of cursing wordpress' SVN-plugin repository. As soon as I bring the SVN and this git-repo together I will do an update to the wordpress hosted download of the plugin..... ;-)

Stay tuned.

;-)

I've just added an option to control weather passwords hashes are saved to the WP userdb. Also, my fork of AuthLDAP returns the user object on success. I'm thinking of adding some options to be able to allow single usernames to be assigned to roles. Especially handy for the administrator role.
I'm not sure, but I don't think the 'authenticate' filter doesn't have to replace the default authentication. For example if AuthLDAP is switched off, you can just return the first argument (you call it $foo) without any form of processing. In that case some more lines of code can be stripped off.

Bests,

Bram

btw nice picture of Veere on your blog ;-)

@brammeleman Sounds great to me! Will you be sending in a PR? I'd love to see that in action.

Oh, and Veere is a MUST every summer ;-) You live up there?

Finally won the struggle against git-svn! The change introduced with #9 now is live in the wordpress-plugin-repository. There have also been minor changes to the master (regarding comments, not code) so you might want to do a rebase or merge.

@heiglandreas heiglandreas referenced this pull request Dec 17, 2014
Closed

Problem with login #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment