From 2aca5c4faef2914a1227bb8a635281793ef8bc6e Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Mon, 11 Nov 2013 21:07:09 +0000 Subject: [PATCH] heimdal: Fix CID 241943 Uninitialized pointer read In the error case without EXTRA_ADDRESSES we access ignore_addresses without initialization Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider --- lib/krb5/get_addrs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/krb5/get_addrs.c b/lib/krb5/get_addrs.c index edb3b044e9..8246504188 100644 --- a/lib/krb5/get_addrs.c +++ b/lib/krb5/get_addrs.c @@ -128,7 +128,8 @@ find_all_addresses (krb5_context context, krb5_addresses *res, int flags) /* Allocate storage for them. */ res->val = calloc(num, sizeof(*res->val)); if (res->val == NULL) { - krb5_free_addresses(context, &ignore_addresses); + if (flags & EXTRA_ADDRESSES) + krb5_free_addresses(context, &ignore_addresses); freeifaddrs(ifa0); return krb5_enomem(context); }