Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Dell Quest local patches #212

Open
jaltman opened this issue Nov 19, 2016 · 5 comments
Open

Review Dell Quest local patches #212

jaltman opened this issue Nov 19, 2016 · 5 comments
Assignees
Milestone

Comments

@jaltman
Copy link
Member

jaltman commented Nov 19, 2016

@dmulder pushed to https://github.com/dmulder/heimdal/tree/vas_modifications over a hundred local patches that were developed for VAS. They need to be reviewed and cherry-picked to Heimdal master as appropriate.

@dmulder
Copy link
Contributor

dmulder commented Aug 21, 2018

I just rebased these against master and cleaned up a few places, if anyone is interested.

@vdukhovni vdukhovni added this to the Heimdal 9 milestone Dec 14, 2018
@lhoward
Copy link
Member

lhoward commented Dec 21, 2018

Apart from a few stylistic issues (indentation etc) these look well written and something I'd be happy to look at integrating in the Heimdal 9 timeframe.

@lhoward lhoward self-assigned this Dec 21, 2018
@lhoward
Copy link
Member

lhoward commented Dec 21, 2018

cc @abartlet

@abartlet
Copy link
Member

So, what I tend to do with a patch series like this is a triage process to cut things down from overwealming to just large.

  • The spelling fixes and typos
  • The compiler fixes (with care!)
  • The easiest of the hard stuff
  • etc

I've worked with @dmulder extensively on Samba as we worked to get GPO functionality in, and with this and a lot of time we were able to take the work of a former Google Summer of Code student and turn it into practical improvements to Samba.

Hard work, but not impossible it you take it a bit at a time.

@abartlet
Copy link
Member

(also a bit like I've been doing to try and filter Samba patches back out of lorikeet-heimdal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants