Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PK-INIT improvements #136

Merged
merged 5 commits into from Jul 24, 2015
Merged

PK-INIT improvements #136

merged 5 commits into from Jul 24, 2015

Conversation

HenryJacques
Copy link
Contributor

This PR add:

  • more support related to common PIN errors (PIN blocked, incorrect, ...)
  • the corresponding messages allowing a more friendly debugging.
  • fix a small typo
  • allow more than one token to be present (if the first is not usable, the second one can be).

Credit: thanks to Romain Sahut for his help.

@HenryJacques
Add new error codes related to PIN
5cf302d 
Not all error codes have been added, only the most common ones.
@HenryJacques
Fix typo
75a304c
@HenryJacques
add error codes related to User PIN
1639697
@HenryJacques
Allow to use more than one token
35a569b 
This is needed if the first is not usable
@HenryJacques
Fix typo
5a4e9d1
HenryJacques added a commit to HenryJacques/pam-krb5 that referenced this pull request Jul 20, 2015
@HenryJacques
Add more friendly error messages with pkinit
a5ee4c6 
This PR depends on whether the HX509_PKCS11_* code are defined in hx509_err.h.
Those are introduced in the Heimdal's PR #136 (heimdal/heimdal#136)
lha pushed a commit that referenced this pull request Jul 24, 2015
Merge pull request #136 from HenryJacques/pkinit_improvements
db4175c 
PK-INIT improvements
@lha lha merged commit db4175c into heimdal:master Jul 24, 2015
@lha
Copy link
Member

lha commented Jul 24, 2015

thanks

@HenryJacques HenryJacques mentioned this pull request Aug 13, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HenryJacques @lha