New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override build date #332

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bmwiedemann

bmwiedemann commented Sep 4, 2017

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This date call is designed to work with both GNU date and BSD date.

Allow to override build date
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This date call is designed to work with both GNU date and BSD date.
@nicowilliams

This comment has been minimized.

Show comment
Hide comment
@nicowilliams

nicowilliams Sep 25, 2017

Contributor

Why don't we just get rid of the Date altogether?

Contributor

nicowilliams commented Sep 25, 2017

Why don't we just get rid of the Date altogether?

@nicowilliams

This comment has been minimized.

Show comment
Hide comment
@nicowilliams

nicowilliams Sep 25, 2017

Contributor

Actually, for releases we shouldn't want the USER, the HOST, nor the DATE.

The only things of interest are:

  • the actual version
  • the HEAD commit hash
Contributor

nicowilliams commented Sep 25, 2017

Actually, for releases we shouldn't want the USER, the HOST, nor the DATE.

The only things of interest are:

  • the actual version
  • the HEAD commit hash
@nicowilliams

How about we drop all of USER, HOST, and DATE? We don't need an option to keep any of those. Just remove them.

@bmwiedemann bmwiedemann referenced this pull request Sep 26, 2017

Closed

Drop build date #336

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Oct 6, 2017

Closing after this was solved slightly differently in master with
6d27e00
469366d

bmwiedemann commented Oct 6, 2017

Closing after this was solved slightly differently in master with
6d27e00
469366d

@bmwiedemann bmwiedemann closed this Oct 6, 2017

@nicowilliams

This comment has been minimized.

Show comment
Hide comment
@nicowilliams

nicowilliams Oct 12, 2017

Contributor

@bmwiedemann Was my fix sufficient for your purporses?

Contributor

nicowilliams commented Oct 12, 2017

@bmwiedemann Was my fix sufficient for your purporses?

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Oct 13, 2017

@nicowilliams it was sufficient, even though I did not set the SOURCE_HOST variable and was building with different hostnames - that is the part I did not understand, but looking into the build VM's filesystem I see

VERSION_HIDDEN const char *heimdal_long_version = "@(#)$Version: Heimdal 7.4.0 by abuild on localhost (x86_64-suse-linux-gnu) 2017-08-03T12:00:00Z $";

bmwiedemann commented Oct 13, 2017

@nicowilliams it was sufficient, even though I did not set the SOURCE_HOST variable and was building with different hostnames - that is the part I did not understand, but looking into the build VM's filesystem I see

VERSION_HIDDEN const char *heimdal_long_version = "@(#)$Version: Heimdal 7.4.0 by abuild on localhost (x86_64-suse-linux-gnu) 2017-08-03T12:00:00Z $";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment