New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[heketi-cli] Inconsistency with the requirement for zone value #236

Closed
lpabon opened this Issue Oct 30, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@lpabon
Contributor

lpabon commented Oct 30, 2015

Description of problem: When the nodes are added through a topology file, zone value isn't mandatory but adding a node through cli expects a zone value.

# heketi-cli -user="admin" -secret="Top Secret" node add -cluster=fe5f47e19eaafb538baa429c734a647c -management-host-name=hostname

Error: Missing zone

But this worked:

heketi-cli load -json=topology.json

$ cat topology.json

{
    "clusters": [
        {
            "nodes": [
                {
                    "node": {
                        "hostnames": {
                            "manage": [
                                "rhshdp04.lab.eng.blr.redhat.com"
                            ],
                            "storage": [
                                "rhshdp04.lab.eng.blr.redhat.com"
                            ]
                        }

                    },
                    "devices": [
                        "/dev/vdb",
                        "/dev/vdc",
                        "/dev/vdd"
                    ]
                }
            ]
         }
     ]
}

@lpabon lpabon added the bug label Oct 30, 2015

@lpabon lpabon self-assigned this Oct 30, 2015

@lpabon lpabon added this to the Release 1.1 milestone Oct 30, 2015

@lpabon

This comment has been minimized.

Show comment
Hide comment
@lpabon

lpabon Nov 3, 2015

Contributor

Zone value of 0 will not be allowed. That will take care of automatically setting a default value of zero when the JSON request is unmarshalled. The API has been update.

Contributor

lpabon commented Nov 3, 2015

Zone value of 0 will not be allowed. That will take care of automatically setting a default value of zero when the JSON request is unmarshalled. The API has been update.

lpabon pushed a commit to lpabon/heketi that referenced this issue Nov 3, 2015

Luis Pabón
Do not allow the default zone value of 0
Closes heketi#236

Signed-off-by: Luis Pabón <lpabon@redhat.com>

@lpabon lpabon added the in progress label Nov 3, 2015

@lpabon lpabon closed this in #241 Nov 3, 2015

@lpabon lpabon removed the in progress label Nov 3, 2015

lpabon pushed a commit to lpabon/heketi that referenced this issue Nov 3, 2015

Luis Pabón
Do not allow the default zone value of 0
Closes heketi#236

Signed-off-by: Luis Pabón <lpabon@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment