Skip to content
This repository has been archived by the owner on Jul 6, 2023. It is now read-only.

Heketi should have a configurable value for setting up max number of snapshots in a volume #419

Closed
lpabon opened this issue Jul 7, 2016 · 2 comments
Closed

Heketi should have a configurable value for setting up max number of snapshots in a volume #419

lpabon opened this issue Jul 7, 2016 · 2 comments
Assignees
@lpabon
Labels
enhancement
Milestone
Release 2

Comments

@lpabon
Copy link
Contributor

lpabon commented Jul 7, 2016

There needs to be a configurable value in the config file and in the environment variable which will be able to set the max number of snapshots in a volume
@lpabon lpabon added this to the Release 2 milestone Jul 7, 2016
@lpabon lpabon self-assigned this Jul 7, 2016
lpabon pushed a commit to lpabon/heketi that referenced this issue Jul 19, 2016
Allow configuration of snapshot limit
dc43897 
This change allows the administrator to set the maximum
limit of snapshots in the configuration file.

If no limit has been specified, then Heketi will not set
a limit and GlusterFS will use its default value.

Closes heketi#419

Signed-off-by: Luis Pabón <lpabon@redhat.com>
@lpabon lpabon mentioned this issue Jul 19, 2016
Merged
lpabon pushed a commit to lpabon/heketi that referenced this issue Jul 20, 2016
Set snapshot limit using environment variable
8df22f4 
Closes heketi#419

Signed-off-by: Luis Pabón <lpabon@redhat.com>
@lpabon lpabon mentioned this issue Jul 20, 2016
Merged
@MohamedAshiqrh
Copy link
Member

@lpabon Hey, can I know where this value been used or set.

I can not find the place it sets the value on gluster snapshot

@MohamedAshiqrh
Copy link
Member

I can see from the PR that sshexec has the snapshot limit setting but when using kubeexec. There is not a place where we set this limit. Let me know If I am wrong.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lpabon lpabon

Labels
enhancement
Projects
None yet
Milestone
Release 2
Development

No branches or pull requests
2 participants
@lpabon @MohamedAshiqrh