Skip to content
This repository has been archived by the owner on Jul 6, 2023. It is now read-only.

Get a 404 error from heketi-cli when requesting a non-hex value id #539

Closed
lpabon opened this issue Oct 5, 2016 · 0 comments
Closed

Get a 404 error from heketi-cli when requesting a non-hex value id #539

lpabon opened this issue Oct 5, 2016 · 0 comments
Assignees
@lpabon
Labels
Backport: Release 3 bug
Milestone
Release 4

Comments

@lpabon
Copy link
Contributor

lpabon commented Oct 5, 2016 

Same applicable for cluster/device/node

#heketi-cli cluster info t
Error: 404 page not found

# heketi-cli device info t
Error: 404 page not found

#heketi-cli node info t
Error: 404 page not found

BZ 1351646
@lpabon lpabon added the bug label Oct 5, 2016
@lpabon lpabon added this to the Release 4 milestone Oct 5, 2016
lpabon pushed a commit to lpabon/heketi that referenced this issue Oct 18, 2016
api: Better invalid path error handler
6fe0a48 
When a path with an illegal id is provided by the caller (something
that does not match the regexp), the Gorilla Mux Router automatically
routed the call to http.NotFoundHandler().  This would be ok for
an API to handle, but the heketi-cli would output information which
was not very human friendly.

Instead, we now provide our own error handler which returns a nicer
error than just "404: Not found".

Closes heketi#539

Signed-off-by: Luis Pabón <lpabon@redhat.com>
@lpabon lpabon mentioned this issue Oct 18, 2016
Merged
@lpabon lpabon self-assigned this Oct 18, 2016
raghavendra-talur pushed a commit to raghavendra-talur/heketi that referenced this issue Nov 17, 2016
@raghavendra-talur
api: Better invalid path error handler
9eff56e 
When a path with an illegal id is provided by the caller (something
that does not match the regexp), the Gorilla Mux Router automatically
routed the call to http.NotFoundHandler().  This would be ok for
an API to handle, but the heketi-cli would output information which
was not very human friendly.

Instead, we now provide our own error handler which returns a nicer
error than just "404: Not found".

Closes heketi#539

Signed-off-by: Luis Pabón <lpabon@redhat.com>
@raghavendra-talur raghavendra-talur mentioned this issue Nov 17, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lpabon lpabon

Labels
Backport: Release 3 bug
Projects
None yet
Milestone
Release 4
Development

No branches or pull requests
1 participant
@lpabon