This repository has been archived by the owner on Jul 6, 2023. It is now read-only.
api: Better invalid path error handler #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a path with an illegal id is provided by the caller (something that does not match the regexp), the Gorilla Mux Router automatically routed the call to http.NotFoundHandler(). This would be ok for an API to handle, but the heketi-cli would output information which was not very human friendly. Instead, we now provide our own error handler which returns a nicer error than just "404: Not found". Closes heketi#539 Signed-off-by: Luis Pabón <lpabon@redhat.com>
|
@heketi/dev Please review when you have time. |
|
Patch looks good to me, 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a path with an illegal id is provided by the caller (something
that does not match the regexp), the Gorilla Mux Router automatically
routed the call to http.NotFoundHandler(). This would be ok for
an API to handle, but the heketi-cli would output information which
was not very human friendly.
Instead, we now provide our own error handler which returns a nicer
error than just "404: Not found".
Closes #539
Signed-off-by: Luis Pabón lpabon@redhat.com