change failed to removed #779
Conversation
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
|
Can one of the admins verify this patch? |
| @@ -28,7 +28,7 @@ const ( | |||
| EntryStateUnknown EntryState = "" | |||
| EntryStateOnline EntryState = "online" | |||
| EntryStateOffline EntryState = "offline" | |||
| EntryStateFailed EntryState = "failed" | |||
| EntryStateFailed EntryState = "removed" | |||
There was a problem hiding this comment.
Please also change the variable throughout the code EntryStateFailed to EntryStateRemoved for completeness
There was a problem hiding this comment.
@lpabon I realised now that EntryStateFailed is a api. Do you really want to change it? It will break backward compatibility.
There was a problem hiding this comment.
True. I think for that reason, this PR cannot be accepted. (API: https://github.com/heketi/heketi/blob/master/pkg/glusterfs/api/types.go#L31 ).
Instead we can always change the string shown in the CLI
|
@heketi/dev Please review |
| @@ -28,7 +28,7 @@ const ( | |||
| EntryStateUnknown EntryState = "" | |||
| EntryStateOnline EntryState = "online" | |||
| EntryStateOffline EntryState = "offline" | |||
| EntryStateFailed EntryState = "failed" | |||
| EntryStateFailed EntryState = "removed" | |||
There was a problem hiding this comment.
True. I think for that reason, this PR cannot be accepted. (API: https://github.com/heketi/heketi/blob/master/pkg/glusterfs/api/types.go#L31 ).
Instead we can always change the string shown in the CLI
|
Closing this PR since it would change the existing API. |
Signed-off-by: Raghavendra Talur rtalur@redhat.com