This repository has been archived by the owner on Jul 6, 2023. It is now read-only.
Change failed to removed in cli #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heketi/maintainers This is PR is result of discussion in #779 |
|
Can one of the admins verify this patch? |
MohamedAshiqrh
force-pushed
the
clifailed
branch
from
e26ff73
to
97af95d
Compare
|
This PR creates a temp variable for removed and replaces the failed to removed. |
lpabon
reviewed
Aug 7, 2017
client/cli/go/cmds/node.go
Outdated
| @@ -265,6 +265,10 @@ var nodeInfoCommand = &cobra.Command{ | |||
| if err != nil { | |||
| return err | |||
| } | |||
| const entryStateRemoved api.EntryState = "removed" | |||
| if info.State == api.EntryStateFailed { | |||
| info.State = entryStateRemoved | |||
There was a problem hiding this comment.
This is good, but quick question? Why create a const? Just in case it is used in the future?
Signed-off-by: mliyazud <mliyazud@redhat.com>
MohamedAshiqrh
force-pushed
the
clifailed
branch
from
97af95d
to
a010b9e
Compare
|
@lpabon PTAL |
|
Sorry, that is not what I meant. I meant just use: info.State = "failed"But it is ok, I'll just merge it and fix that later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mliyazud mliyazud@redhat.com