Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: semantic instead of lexical version compare #724

Merged
merged 1 commit into from Jan 13, 2018
Merged

Conversation

ppannuto
Copy link
Member

Pull Request Overview

Addresses the problem raised in #717.

This is a bit obnoxious to do in a cross-platform way, but this pure-bash
solution should work according to the wonderful wonderful Internet.

Testing Strategy

Running the script with faked versions to make sure it did the right thing.

TODO or Help Wanted

Documentation Updated

  • Kernel: The relevant files in /docs have been updated or no updates are required.
  • Userland: The application README has been added, updated, or no updates are required.

Formatting

  • make formatall has been run.

This is a bit obnoxious to do in a cross-platform way, but this pure-bash
solution should work according to the wonderful wonderful Internet.
Copy link
Contributor

@brghena brghena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes things for me

@brghena brghena merged commit 09ed0a5 into master Jan 13, 2018
@ppannuto ppannuto deleted the semver-in-bash branch January 13, 2018 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants