-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReaLearn main FX window, Mapping Panel UI seems not to respect OS window theme #136
Comments
This is also the same on Mac OS at the moment. Although it is a lot worse and isn't really usable since you can see very little after you click 'add one' |
@GavinRay97 Cool, how did you get this look? I want it, too :) Yes, both the macOS and Windows issues have the same cause. Fixing ASAP. |
@GavinRay97 On macOS, it's fixed. For Windows, I'm trying to find the correct way to determine when to use a dark background color. Any chance you can point me into the right direction with the Win32 API? AFAIK, what you use is not some kind of official dark mode but rather a custom theme, so I would probably need to determine the most relevant theme background color. Once I have that, I could decide whether to paint a dark or a bright background color. A quick alternative would be to just use the default color, but then the mapping rows would look as boringly grey as they looked in the previous version. |
Hey @helgoboss =D Yeah it's a really nice theme, especially with dark REAPER themes, it hides all the ugly white parts that stick out. So it's this theme: (The "Night" variant of the theme) To be applied, you'll need to use: I've attached the theme directly in a zip to save you having to sign up for Deviant Art to download 🙂 (though feel free to do that obviously if you want)
I wish I could. I have some other unofficial themes that are very similar to this one, and they don't theme this parts of the REAPER UI right either, so I think it may be a more obscure/less common Win32 element. Sorry not to be more helpful, I've never actually interacted with the Win32 API 🙁
Yeah that would totally work too, and would be easy. I would be okay with this too (I mean, I'm okay with how it is now, it's mostly readable). Perhaps an option tucked in menu somewhere for the ~dozen or so users using weird custom themes like this? This is REAPER before/after patched theme, if curious: |
…her dark window background in this case, use default color
Found a way to get the theme color. I calculate the luminance of that color and if it's on the dark side, I use the default background instead of the white color. Works with the theme that you use and hopefully also with others. |
Not a big deal, and this is a custom/unofficially patched Windows system theme, but just thought I'd point this out:
The text was updated successfully, but these errors were encountered: