Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to conditional activation #43

Closed
jackmau opened this issue Oct 7, 2020 · 2 comments
Closed

Improvements to conditional activation #43

jackmau opened this issue Oct 7, 2020 · 2 comments
Labels
bug Something isn't working realearn Related to ReaLearn
Milestone

Comments

@jackmau
Copy link

jackmau commented Oct 7, 2020

Hi @helgoboss ,
first of all congratulation for including this feature, I found it really useful for my workflow. It overall works well but there are a couple of issues on my end (Reaper 5.99, Windows x64).

  1. Realearn (and reaper) crash every time I try to visualise automation lane for the new Parameters.
  2. When using conditional activation with program selected (the one I found more useful for my purposes) I am annoyed by the mismatch created by the 0-indexing structure of Rust (or reaper C++ API?), i.e. a parameter with program 1 selected is actually seen as 0, 2 as 0.01 and so on, this makes assigning parameter value from another realearn instance painful, as I always have to remember to add 1 to get to my target. It would be helpful if either parameter program would start from 0 or the underlying parameter values would start from 1.
@helgoboss
Copy link
Owner

@jackmau I could reproduce the crash. Looking into it.

@helgoboss helgoboss added this to the 1.12.0 milestone Dec 9, 2020
@helgoboss helgoboss added the bug Something isn't working label Dec 9, 2020
@helgoboss
Copy link
Owner

Concerning number 2, I agree this is confusing. I will let the program numbers start with 0. Letting the parameter start from 1 (0.01) would be a breaking change and would raise the question what parameter value 0.00 is supposed to mean then.

helgoboss added a commit that referenced this issue Dec 10, 2020
in order to make it more in line with the parameter values
helgoboss added a commit that referenced this issue Dec 14, 2020
@helgoboss helgoboss added the realearn Related to ReaLearn label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working realearn Related to ReaLearn
Projects
None yet
Development

No branches or pull requests

2 participants