Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua import of poll_for_feedback not working #517

Closed
vonglan opened this issue Jan 5, 2022 · 2 comments
Closed

Lua import of poll_for_feedback not working #517

vonglan opened this issue Jan 5, 2022 · 2 comments
Labels
bug Something isn't working high priority

Comments

@vonglan
Copy link

vonglan commented Jan 5, 2022

  • When I import from Lua, with no mention of poll_for_feedback, the mapping exports as poll_for_feedback = false
  • When I set „poll for feedback“ via the GUI, the mapping exports without a mention of poll_for_feedback
  • When I set poll for feedback=true in Lua, then import this, the "pol for feedback" in the GUI is still unticked

rc.4

By the way:
Why are some defaults (e.g. step_size_interval, step_factor_interval) part of the Lua Export?

@helgoboss helgoboss added bug Something isn't working high priority labels Jan 6, 2022
@helgoboss
Copy link
Owner

  • When I import from Lua, with no mention of poll_for_feedback, the mapping exports as poll_for_feedback = false
  • When I set „poll for feedback“ via the GUI, the mapping exports without a mention of poll_for_feedback
  • When I set poll for feedback=true in Lua, then import this, the "pol for feedback" in the GUI is still unticked

rc.4

Thanks, will look into it in a few days.

By the way: Why are some defaults (e.g. step_size_interval, step_factor_interval) part of the Lua Export?

They are not the defaults for Lua, just for the GUI. Because I don't like this 1-to-5 default, at least for programming, which is supposed to be precise and where defaults usually are something like 0 or 1. It sounds too arbitrary.

@helgoboss
Copy link
Owner

  • When I import from Lua, with no mention of poll_for_feedback, the mapping exports as poll_for_feedback = false
  • When I set „poll for feedback“ via the GUI, the mapping exports without a mention of poll_for_feedback
  • When I set poll for feedback=true in Lua, then import this, the "pol for feedback" in the GUI is still unticked

Good catch. This was a missing assignment. Fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

No branches or pull requests

2 participants