Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Edit mapping' window not fully visible/cut off vertically #589

Closed
nofishonfriday opened this issue Jun 8, 2022 · 10 comments
Closed

'Edit mapping' window not fully visible/cut off vertically #589

nofishonfriday opened this issue Jun 8, 2022 · 10 comments
Labels
bug Something isn't working high priority realearn Related to ReaLearn

Comments

@nofishonfriday
Copy link

nofishonfriday commented Jun 8, 2022 •
edited
Loading

On my laptop (Thinkpad T420, Win10, resolution: 1920*1080, native, Windows display scaling: 150%, recommended, no other scaling settings active) I can't fully see/access the 'Edit mapping' window vertically.

Related forum posts: 2278, 2282, 2287ff.

Screenshot:
https://i.imgur.com/bvs6GKL.png
@helgoboss helgoboss added the bug Something isn't working label Jun 8, 2022
@helgoboss
Copy link
Owner

I'll wait with this until #576 is through.

helgoboss added a commit that referenced this issue Jun 10, 2022
@helgoboss
#589 Start writing a dialog file generator
4faefcd
helgoboss added a commit that referenced this issue Jun 10, 2022
@helgoboss
#589 Finish generating group and header panel
35e79fb
helgoboss added a commit that referenced this issue Jun 10, 2022
@helgoboss
#589 Also generate mapping row panel
5ca1ef7
helgoboss added a commit that referenced this issue Jun 10, 2022
@helgoboss
#589 Make rect transformable by context
98afb65
helgoboss added a commit that referenced this issue Jun 10, 2022
@helgoboss
#589 Make styles additive
2de01f4
helgoboss added a commit that referenced this issue Jun 10, 2022
@helgoboss
#589 Never include WS_TABSTOP in convenience control functions
0489774
helgoboss added a commit that referenced this issue Jun 11, 2022
@helgoboss
#589 Generate more panels
17e14da
helgoboss added a commit that referenced this issue Jun 11, 2022
@helgoboss
#589 Also generate main and YAML editor panel
2cb3304
helgoboss added a commit that referenced this issue Jun 11, 2022
@helgoboss
#589 Generate mapping, source and target controls of mapping panel
4da6e75
helgoboss added a commit that referenced this issue Jun 11, 2022
@helgoboss
#589 Generate mapping panel completely
872eef8
helgoboss added a commit that referenced this issue Jun 11, 2022
@helgoboss
#589 Restore previous msvc.rc
a4d0049 
accidentally deleted a section
helgoboss added a commit that referenced this issue Jun 11, 2022
@helgoboss
#589 Fix a few generated panels, should be equivalent to the previous…
fc6c56f 
… resource file now
helgoboss added a commit that referenced this issue Jun 11, 2022
@helgoboss
#589 Remove dependence on menu resources, always generate menus on-th…
02332f7 
…e-fly
helgoboss added a commit that referenced this issue Jun 11, 2022
@helgoboss
#589 Use generated rc and header file from now on
c4b46be
helgoboss added a commit that referenced this issue Jun 11, 2022
@helgoboss
#589 Make scaling possible
d165a40
helgoboss added a commit that referenced this issue Jun 11, 2022
@helgoboss
#589 Prevent some of the overlapping with lower scale factors
c00d460
@helgoboss
Copy link
Owner

@nofishonfriday I managed to decrease the size of the mapping window by reducing the vertical spacing and button heights.

Does the main window fit on your screen? The mapping window is now even a bit smaller than that one: https://i.imgur.com/5zjZ71i.png

This was referenced Jun 12, 2022
Closed
Closed
@nofishonfriday
Copy link
Author

nofishonfriday commented Jun 12, 2022 •
edited
Loading

Main windows does fit on screen vertically in default size (though a bit tight, see screenshot), so I guess mapping window should now too with this change.
Thank you!

https://i.imgur.com/9DraD7x.png

@helgoboss
Copy link
Owner

According to your screenshot it doesn't fit. The footer is cut off completely. Then let's see. Maybe I can make decrease the spacing for the main window as well.

Let me know if the mapping panel fits with the new pre.6.

@nofishonfriday
Copy link
Author

Oh there's a footer. :D
Just tried pre6, surprisingly (to your statement above) the mapping window is still a bit taller than the main window.
But it fits.

https://i.imgur.com/V3Lo4d3.png

@helgoboss
Copy link
Owner

It really is smaller than the main window. You just get the impression that it isn't because you don't see the complete main window 😆

@nofishonfriday
Copy link
Author

Duh, makes sense. :)

helgoboss added a commit that referenced this issue Jun 13, 2022
@helgoboss
#589 Scale at RC generation time on Linux as well
ac5b2b7
helgoboss added a commit that referenced this issue Jun 13, 2022
@helgoboss
#589 Make Linux dialogs use less screen space
a144126
helgoboss added a commit that referenced this issue Jun 13, 2022
@helgoboss
#589 Multiple changes
93db465 
- Decrease main panel height
- More DRY (don't repeat widths and heights)
- Enforce minimum text height
- Improve dimensions for some specific controls
- Looks good on Windows hidpi
helgoboss added a commit that referenced this issue Jun 13, 2022
@helgoboss
#589 Display only 5 mapping rows in main panel
e912e36 
to make it fit even on small resolutions or high OS scalings
helgoboss added a commit that referenced this issue Jun 13, 2022
@helgoboss
#589 Fix footer positioning
27b7f04
helgoboss added a commit that referenced this issue Jun 13, 2022
@helgoboss
#589 Fix cut off radio buttons on macOS
409246f
helgoboss added a commit that referenced this issue Jun 13, 2022
@helgoboss
#589 Make sure the order of declarations in the bindings file stays t…
7a69b58 
…he same

prevents merge conflicts
helgoboss added a commit that referenced this issue Jun 13, 2022
@helgoboss
#589 Increase width on Linux a bit because radio button text cut off
103db4a
@helgoboss
Copy link
Owner

In pre.7, the main panel should be smaller as well. I decided to give it 5 rows only instead of 6 to make sure it fits. I also made improvements regarding the layout/sizes on Windows, macOS and Linux.

@nofishonfriday
Copy link
Author

It's good now since pre7, thank you!
https://i.imgur.com/PIiptVz.png

@helgoboss
Copy link
Owner

Awesome. Happy the effort worked out. These changes luckily made the GUI more maintainable in general.

@helgoboss helgoboss added the realearn Related to ReaLearn label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high priority realearn Related to ReaLearn
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@helgoboss @nofishonfriday