Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control surface metrics #80

Closed
helgoboss opened this issue Jan 3, 2021 · 0 comments
Closed

Control surface metrics #80

helgoboss opened this issue Jan 3, 2021 · 0 comments
Labels
realearn Related to ReaLearn
Milestone
2.0.1

Comments

@helgoboss
Copy link
Owner

ReaLearn's logic is for the most part executed on the main thread and almost completely (except from UI interactions) done in IReaperControlSurface callback methods. It would be great if we could get some metrics about how long it takes to execute the callback methods in order to be able to detect and analyze performance regressions.
@helgoboss helgoboss added this to the 1.12.0 milestone Jan 3, 2021
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Add control surface metering
6c6ba64 
- Logs complete metrics to console on demand (as part of "Log debug info")
- Logs single metrics to console whenever considered critical
- For both reaper-rs control surface and ReaLearn control surface (each instance)
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Add dummy endpoint /realearn/metrics
1ff065c
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Use latest reaper-rs which has rxRust in separate crate
bfa2c8e
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Use call_once() instead of once_cell::unsync::Lazy to create glob…
b276827 
…al variables

should now be safe
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Use one global ControlSurface surface instead of one per instance
4bad729 
- Makes performance measuring easier.
- Makes it easier to use change detection logic in main processors without Rx.
- Now ReaLearn registers only 2 surfaces globally: The reaper-rs surface for executing
  arbitrary code in the main thread and the ReaLearn control surface for handling
  events.
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Expose metrics in Prometheus format
b776ff1
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Expose metrics in Prometheus format, now complete, without delay …
6e8f60b 
…and on demand
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Do without control-surface-meter feature (adjust to latest reaper…
617a35a 
…-rs)
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Add prefix "realearn_" to Prometheus metrics
cea0cf9
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Adjust to latest reaper-rs
39fa838
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Put do_later functions into Global
9c6fae1
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Put future functions into Global
c215f93
helgoboss added a commit that referenced this issue Jan 4, 2021
@helgoboss
#80 Record metrics only if REALEARN_METER env variable is set
1c9c97f
helgoboss added a commit that referenced this issue Jan 8, 2021
@helgoboss
#80 Make action picking work again
fe48464
helgoboss added a commit that referenced this issue Jan 13, 2021
@helgoboss
#80 Remove main processor from control surface in sync when plug-in u…
ce65ec4 
…nloaded

- Before it was done async but in theory that can cause panics on sends (receiver gone)
  and domain event handler notification (weak session not upgradeable).
- Also log app state when using "Log debug info".
- Also add some comments of intended real-time processor removal tactics.
@helgoboss helgoboss added the realearn Related to ReaLearn label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
realearn Related to ReaLearn
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
1 participant
@helgoboss