Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feedback when reverse enabled and target range non-symmetric #111

Closed
helgoboss opened this issue Jan 23, 2021 · 1 comment
Closed

Fix feedback when reverse enabled and target range non-symmetric #111

helgoboss opened this issue Jan 23, 2021 · 1 comment
Labels
bug Something isn't working
Milestone
2.0.1

Comments

@helgoboss
Copy link
Owner

Feedback stops at some point when target range exceeded. This shouldn't be the case because without reverse the whole range is used.

Additionally, "Reverse" should be on the right side because it affects encoders, even in control direction.
@helgoboss helgoboss added the bug Something isn't working label Jan 23, 2021
@helgoboss helgoboss added this to the 1.12.0 milestone Jan 23, 2021
@helgoboss
Copy link
Owner Author

This only happened when target range non-symmetric (min != inversion of max).

@helgoboss helgoboss changed the title Fix feedback when reverse enabled and target range restricted Fix feedback when reverse enabled and target range non-symmetric Jan 23, 2021
helgoboss added a commit that referenced this issue Jan 23, 2021
@helgoboss
#111 Merge two mapping panel tuning section group boxes
b3cb77a 
"Reverse" should have been on the right side because it affects encoders,
even in control direction. But on the right side there was no space anymore.
So what. Let's merge both sides.
helgoboss added a commit that referenced this issue Jan 23, 2021
@helgoboss
#111 Fix feedback when reverse enabled and target range non-symmetric
7a87d4d
helgoboss added a commit that referenced this issue Jan 25, 2021
@helgoboss
#117 #111 Implement feedback reverse behavior in a more understandabl…
95e22cd 
…e way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
1 participant
@helgoboss