Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't apply "fail-fast" when controlling, too annoying #177

Closed
helgoboss opened this issue Feb 25, 2021 · 0 comments
Closed

Don't apply "fail-fast" when controlling, too annoying #177

helgoboss opened this issue Feb 25, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@helgoboss
Copy link
Owner

helgoboss commented Feb 25, 2021

Here's one error that popped up: "assertion failed: 0.0 <= normalized_value || normalized_value.is_nan()".

Other errors could pop up because control() can return an error and this error was just unwrapped.

--- cut ---
Module name:         ReaLearn
Module version:      v2.3.2/x86_64 rev 21d4e6 (2021-02-23 23:12:10 UTC)
Module base address: 0x7fff15350000
Module size:         0xbbe000

Message: assertion failed: 0.0 <= normalized_value || normalized_value.is_nan()

   0:     0x7fff15a9a5bd - Extended
   1:     0x7fff15a98ad9 - Extended
   2:     0x7fff1598fa7f - MAIN
   3:     0x7fff15ab72e0 - Extended
   4:     0x7fff15ab6d83 - Extended
   5:     0x7fff15ab416f - Extended
   6:     0x7fff15ab6d09 - Extended
   7:     0x7fff15aca440 - rust_eh_personality
   8:     0x7fff15aca38c - rust_eh_personality
   9:     0x7fff159abaaa - MAIN
  10:     0x7fff1562440f - DllMain
  11:     0x7fff156c470b - DllMain
  12:     0x7fff156c519e - DllMain
  13:     0x7fff1544eac6 - NSEEL_HOSTSTUB_EnterMutex
  14:     0x7fff154c8669 - NSEEL_HOSTSTUB_EnterMutex
  15:     0x7fff1541f4dc - NSEEL_HOSTSTUB_EnterMutex
  16:     0x7fff159ed64f - Run
  17:        0x1402738b8 - <unknown>
  18:        0x14019344a - <unknown>
  19:        0x140192668 - <unknown>
  20:        0x1403b3511 - <unknown>
  21:     0x7fff7e6d2920 - ScreenToClient
  22:     0x7fff7e6d20c2 - ScreenToClient
  23:     0x7fff7e719f99 - UnpackDDElParam
  24:     0x7fff7e6ce858 - CallWindowProcW
  25:     0x7fff7e6ce299 - DispatchMessageW
  26:        0x1403acd99 - <unknown>
  27:        0x140886eb1 - <unknown>
  28:     0x7fff7f217034 - BaseThreadInitThunk
  29:     0x7fff801dd241 - RtlUserThreadStart
--- cut ---

With symbols resolved:

Attempting to resolve symbols for 30 addresses
==============================================
        
0: 7fff15a9a5bd
-----------------------------------
            
Relative: Some(74a5bd)
Ours absolute: Some(7fff78bca5bd)

7fff78bca530
backtrace::backtrace::trace<closure-0>
C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\backtrace-0.3.53\src\backtrace\mod.rs (line 53)


1: 7fff15a98ad9
-----------------------------------
            
Relative: Some(748ad9)
Ours absolute: Some(7fff78bc8ad9)

7fff78bc8a80
backtrace::capture::Backtrace::new
C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\backtrace-0.3.53\src\capture.rs (line 140)


2: 7fff1598fa7f
-----------------------------------
            
Relative: Some(63fa7f)
Ours absolute: Some(7fff78abfa7f)

7fff78abfa40
reaper_high::log_util::create_reaper_panic_hook::{{closure}}<closure-0>
C:\Users\runneradmin\.cargo\git\checkouts\reaper-rs-d32fed07113e6874\ee3af06\main\high\src\log_util.rs (line 51)


3: 7fff15ab72e0
-----------------------------------
            
Relative: Some(7672e0)
Ours absolute: Some(7fff78be72e0)

7fff78be7170
std::panicking::rust_panic_with_hook
/rustc/f0f68778f798d6d34649745b41770829b17ba5b8\/library\std\src\panicking.rs (line 595)


4: 7fff15ab6d83
-----------------------------------
            
Relative: Some(766d83)
Ours absolute: Some(7fff78be6d83)

7fff78be6d10
std::panicking::begin_panic_handler::{{closure}}
/rustc/f0f68778f798d6d34649745b41770829b17ba5b8\/library\std\src\panicking.rs (line 495)


5: 7fff15ab416f
-----------------------------------
            
Relative: Some(76416f)
Ours absolute: Some(7fff78be416f)

7fff78be4150
std::sys_common::backtrace::__rust_end_short_backtrace<closure-0,!>
/rustc/f0f68778f798d6d34649745b41770829b17ba5b8\/library\std\src\sys_common\backtrace.rs (line 141)


6: 7fff15ab6d09
-----------------------------------
            
Relative: Some(766d09)
Ours absolute: Some(7fff78be6d09)

7fff78be6cc0
std::panicking::begin_panic_handler
/rustc/f0f68778f798d6d34649745b41770829b17ba5b8\/library\std\src\panicking.rs (line 493)


7: 7fff15aca440
-----------------------------------
            
Relative: Some(77a440)
Ours absolute: Some(7fff78bfa440)

7fff78bfa410
core::panicking::panic_fmt
/rustc/f0f68778f798d6d34649745b41770829b17ba5b8\/library\core\src\panicking.rs (line 92)


8: 7fff15aca38c
-----------------------------------
            
Relative: Some(77a38c)
Ours absolute: Some(7fff78bfa38c)

7fff78bfa340
core::panicking::panic
/rustc/f0f68778f798d6d34649745b41770829b17ba5b8\/library\core\src\panicking.rs (line 50)


9: 7fff159abaaa
-----------------------------------
            
Relative: Some(65baaa)
Ours absolute: Some(7fff78adbaaa)

7fff78adb9c0
reaper_high::volume::Volume::from_reaper_value
C:\Users\runneradmin\.cargo\git\checkouts\reaper-rs-d32fed07113e6874\ee3af06\main\high\src\volume.rs (line 27)


10: 7fff1562440f
-----------------------------------
            
Relative: Some(2d440f)
Ours absolute: Some(7fff7875440f)

7fff78754280
realearn::domain::reaper_target::{{impl}}::current_value
D:\a\realearn\realearn\main\src\domain\reaper_target.rs (line 1375)


11: 7fff156c470b
-----------------------------------
            
Relative: Some(37470b)
Ours absolute: Some(7fff787f470b)

7fff787f4650
helgoboss_learn::mode::mode_struct::Mode<realearn::domain::eel_transformation::EelTransformation>::control_absolute_normal<realearn::domain::eel_transformation::EelTransformation,realearn::domain::reaper_target::ReaperTarget>
D:\a\realearn\realearn\main\lib\helgoboss-learn\src\mode\mode_struct.rs (line 193)


12: 7fff156c519e
-----------------------------------
            
Relative: Some(37519e)
Ours absolute: Some(7fff787f519e)

7fff787f4fa0
helgoboss_learn::mode::mode_struct::Mode<realearn::domain::eel_transformation::EelTransformation>::control<realearn::domain::eel_transformation::EelTransformation,realearn::domain::reaper_target::ReaperTarget>
D:\a\realearn\realearn\main\lib\helgoboss-learn\src\mode\mode_struct.rs (line 132)


13: 7fff1544eac6
-----------------------------------
            
Relative: Some(feac6)
Ours absolute: Some(7fff7857eac6)

7fff7857ea40
realearn::domain::mapping::MainMapping::control_if_enabled
D:\a\realearn\realearn\main\src\domain\mapping.rs (line 236)


14: 7fff154c8669
-----------------------------------
            
Relative: Some(178669)
Ours absolute: Some(7fff785f8669)

7fff785f8180
realearn::domain::main_processor::MainProcessor<alloc::rc::Weak<core::cell::RefCell<realearn::application::session::Session>>>::run_all<alloc::rc::Weak<core::cell::RefCell<realearn::application::session::Session>>>
D:\a\realearn\realearn\main\src\domain\main_processor.rs (line 112)


15: 7fff1541f4dc
-----------------------------------
            
Relative: Some(cf4dc)
Ours absolute: Some(7fff7854f4dc)

7fff7854e530
realearn::domain::control_surface::RealearnControlSurfaceMiddleware<alloc::rc::Weak<core::cell::RefCell<realearn::application::session::Session>>>::run_internal<alloc::rc::Weak<core::cell::RefCell<realearn::application::session::Session>>>
D:\a\realearn\realearn\main\src\domain\control_surface.rs (line 196)


16: 7fff159ed64f
-----------------------------------
            
Relative: Some(69d64f)
Ours absolute: Some(7fff78b1d64f)

7fff78b1d630
reaper_low::control_surface::Run
C:\Users\runneradmin\.cargo\git\checkouts\reaper-rs-d32fed07113e6874\ee3af06\main\low\src\control_surface.rs (line 219)
@helgoboss helgoboss added the bug Something isn't working label Feb 25, 2021
@helgoboss helgoboss changed the title Error "assertion failed: 0.0 <= normalized_value || normalized_value.is_nan()" Don't apply "fail-fast" when controlling, too annoying Feb 25, 2021
helgoboss added a commit that referenced this issue Feb 26, 2021
#156 Add "Exclusive" dropdown to all "track property on/off"-style targets
#177 Don't annoyingly popup error messages when controlling with strange settings
#179 Fix bug that causes "Track selection" target to be learned with wrong track
#180 Fix bug that causes fluctuating/wrong feedback for the "Selected track" target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant