Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to send FX parameter feedback even if REAPER not informed about change #350

Closed
helgoboss opened this issue May 1, 2021 · 4 comments
Closed
Labels
enhancement New feature or request high priority

Comments

@helgoboss
Copy link
Owner

e.g. when changing Zebra2 preset using its GUI

@helgoboss helgoboss added the enhancement New feature or request label May 1, 2021
@helgoboss
Copy link
Owner Author

Mmh, no IReaperControlSurface callback at all. Asked Justin if he could add one because REAPER seems to get notified at least of the preset name change.

@helgoboss
Copy link
Owner Author

Justin suggested GetProjectStateChangeCount() but this doesn't increase when e.g. changing Zebra2 preset using its GUI, so another dead end.

Turns out, CSI just uses polling which of course works.

Let's equip ReaLearn with an option to also use polling for the few targets that don't work reliably with REAPER's "notification system":

  • FX: Set parameter value (doesn't work with REAPER's own notification system if it's a monitoring FX or when switching presets within some plug-in GUIs)
  • Track: Enable/disable FX
  • Track: Show/hide
  • FX: Enable/disable
  • Send: Mute/unmute

That also means we need to check if the feedback value would change (save previously calculated value).

@helgoboss
Copy link
Owner Author

On this occasion, hide checkboxes "Send feedback after control" and "Prevent echo feedback" of feedback disabled.

helgoboss added a commit that referenced this issue May 15, 2021
- To avoid feedback processing without any target value changes.
- Testable with "Track: Peak" target.
helgoboss added a commit that referenced this issue May 15, 2021
because it's irritating with motor faders that react on same-value
feedback
helgoboss added a commit that referenced this issue May 15, 2021
@helgoboss
Copy link
Owner Author

helgoboss commented May 15, 2021

Implementation:

  • Add "Poll for feedback" to targets that don't support automatic feedback or not in all situations.
  • Enable it by default without additional JSON, also for old presets.
  • Only send feedback if polled target value has changed.
  • Don't send all feedback on play/resume. That fixes the shaking/nervous motor faders.

helgoboss added a commit that referenced this issue May 15, 2021
…rget

makes feedback update work e.g. when changing preset via FX GUI
helgoboss added a commit that referenced this issue May 15, 2021
helgoboss added a commit that referenced this issue May 15, 2021
don't consider as changed when change insignificant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority
Projects
None yet
Development

No branches or pull requests

1 participant