Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapping groups #85

Closed
helgoboss opened this issue Jan 5, 2021 · 0 comments
Closed

Mapping groups #85

helgoboss opened this issue Jan 5, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone
2.0.1

Comments

@helgoboss
Copy link
Owner

Main purpose: Allow to set activation condition for a whole group of mappings (makes many conditional activation use cases easier to manage).

Other nice usages:

  • Might make it easier to keep track if there are many mappings.
  • A whole group of mappings could be enabled/disabled.
  • Would make it much easier to implement and understand Feedback groups #14.
@helgoboss helgoboss added the enhancement New feature or request label Jan 5, 2021
@helgoboss helgoboss added this to the 1.12.0 milestone Jan 5, 2021
helgoboss added a commit that referenced this issue Jan 6, 2021
@helgoboss
#85 Implement shared group/mapping panel
fe225db
helgoboss added a commit that referenced this issue Jan 6, 2021
@helgoboss
#85 Actually use the shared group/mapping panel
826cd35
helgoboss added a commit that referenced this issue Jan 6, 2021
@helgoboss
#85 Pave the way for an and-linked group activation condition in doma…
1acfd78 
…in layer

- First activation condition will be the most significant one. It's set to
  "Always" at the moment but it will be replaced by the mapping group condition later.
- This should not have changed any behavior so far.
- It was necessary to introduce a separate activation condition to domain layer because
  the condition evaluation logic is there.
- It was also necessary to add another activation flag in order to be able to correctly
  detect the final activation result if just one of the activation conditions was affected
  by a given parameter change.
- An alternative would have been to introduce the concept of groups to the domain layer
  but this seems unnecessary as groups are just intended for easier management, which is
  responsibility of the application layer.
helgoboss added a commit that referenced this issue Jan 6, 2021
@helgoboss
#85 Implement addition and removal of groups, not yet persistent
69ee0f0
helgoboss added a commit that referenced this issue Jan 7, 2021
@helgoboss
#85 Make groups editable
f7f7491
helgoboss added a commit that referenced this issue Jan 7, 2021
@helgoboss
#85 Allow moving mappings to groups etc.
d03003a
helgoboss added a commit that referenced this issue Jan 7, 2021
@helgoboss
#85 Save/restore groups with session
31ecd4f
helgoboss added a commit that referenced this issue Jan 7, 2021
@helgoboss
#85 Allow data to be set for main group, too
6b21487
helgoboss added a commit that referenced this issue Jan 7, 2021
@helgoboss
#85 Switch to main group when everything changes (including groups)
1a0cf82
helgoboss added a commit that referenced this issue Jan 7, 2021
@helgoboss
#85 Sync group activation condition, at least for single mapping
bac56ab
helgoboss added a commit that referenced this issue Jan 7, 2021
@helgoboss
#85 Represent main group using default GroupId
a44df2e 
much more elegant and less code!
helgoboss added a commit that referenced this issue Jan 7, 2021
@helgoboss
#85 Rename main group to default group
18e0ee9
helgoboss added a commit that referenced this issue Jan 8, 2021
@helgoboss
#85 Make escape key working again when in mapping/group name edit field
e722e27
helgoboss added a commit that referenced this issue Jan 8, 2021
@helgoboss
#85 Propagate group settings to main processor, fix some bugs
5062c78
helgoboss added a commit that referenced this issue Jan 8, 2021
@helgoboss
#85 Make mapping up/down buttons work as expected within group
c312d59
helgoboss added a commit that referenced this issue Jan 13, 2021
@helgoboss
#85 Change <Main> to <Default> in row panel context menu
7fdaf75
helgoboss added a commit that referenced this issue Jan 13, 2021
@helgoboss
#85 Correctly gray out disabled entries on macOS and Linux
a10d415
helgoboss added a commit that referenced this issue Jan 25, 2021
@helgoboss
#85 Sync whenever a mapping changes it groups - because it could have…
bd0c6e7 
… changes its activation state
helgoboss added a commit that referenced this issue Jan 25, 2021
@helgoboss
#85 When removing group, don't ask if it should delete mappings if gr…
00ea7dc 
…oup doesn't contain any
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
1 participant
@helgoboss