Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change allowed_probes of mms.py #719

Merged
merged 2 commits into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@dupuisIRT
Copy link

commented Jun 4, 2019

I also added a parameter to test_mms.py to check both probes '1' and '4'

Romain Dupuis added some commits Jun 4, 2019

@dupuisIRT

This comment has been minimized.

Copy link
Author

commented Jun 4, 2019

PR associated to #716

@dstansby dstansby added this to the 0.7.1 milestone Jun 4, 2019

@dstansby
Copy link
Collaborator

left a comment

Thanks a lot for fixing this 👍

@dstansby dstansby merged commit 66bdebb into heliopython:master Jun 4, 2019

7 checks passed

LGTM analysis: Python No new or fixed alerts
Details
Travis CI - Pull Request Build Passed
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 87.17%)
Details
codecov/project 87.17% (+0%) compared to bc0b74d
Details
giles Click details to preview the documentation build
Details
heliopython.heliopy Build #20190604.2 succeeded
Details

@dstansby dstansby referenced this pull request Jun 4, 2019

Closed

MMS bug with probe 0/4 #716

dstansby added a commit to dstansby/heliopy that referenced this pull request Jun 6, 2019

dstansby added a commit that referenced this pull request Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.