Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

try to be more memory-efficient when loading snapshots #599

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

evanmcc
Copy link
Contributor

@evanmcc evanmcc commented Aug 27, 2020

No description provided.

@@ -1554,6 +1570,18 @@ get_snapshot(Height, #blockchain{db=DB, snapshots=SnapshotsCF}=Blockchain) ->
Error
end.

-spec have_snapshot(integer(), blockchain()) ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec would be wrong cuz Error -> Error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix

Copy link
Member

@vihu vihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evanmcc evanmcc merged commit ed1b2c6 into master Aug 28, 2020
@evanmcc evanmcc deleted the pevm/lighter-snap branch August 28, 2020 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants