Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nebra hotspots #175

Merged
merged 14 commits into from Feb 18, 2021
Merged

Add Nebra hotspots #175

merged 14 commits into from Feb 18, 2021

Conversation

ryanteck
Copy link
Contributor

@ryanteck ryanteck commented Feb 9, 2021

I believe I've done this right as per the Manufacturer's docs.

This PR should add the icons and screens for the Nebra Hotspots.

Resolves #153

Screenshots:

Screenshot_20210209-165150
Screenshot_20210209-165146
Screenshot_20210209-165133
Screenshot_20210209-165127
Screenshot_20210209-164827

@tyler-whitman
Copy link
Contributor

Hey Ryan, thanks for submitting this PR. It is looking great, I left you some comments for improvements. Let me know if you want to jump on a discord call to discuss.

@ryanteck
Copy link
Contributor Author

ryanteck commented Feb 9, 2021

Hi Tyler, No problem.

I expected it to not be quite right as I'm not a Typescript / React developer and was just going roughly based on the docs.

All the comments make sense, but can discuss further via Discord if you like. I'm @ryanteck#42.

Copy link
Member

@allenan allenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge

@tyler-whitman tyler-whitman merged commit d7800d3 into helium:main Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Nebra Hotspots to App
3 participants