This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Make the smallest bloom filter 1000 elements #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On new networks, the actual gateway count can be 0 which causes a crash in miner that prevents blocks from syncing.
evanmcc
approved these changes
Jun 9, 2022
JayKickliter
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Looks good, and thanks for the descriptive comments.
For other reviwers: there's an upstream erbloom PR to not panic on size==0, but even with that fix we'd still get a badmatch here, so the fix in this PR seems like a good idea.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem to solve: On new networks, the actual gateway count can be 0 which causes a crash in miner that prevents blocks from syncing.
Solution: Make the size of the new filter at least 1000, and if it's larger, use the actual gateway count for filter sizing.