Skip to content

Conversation

@kurotych
Copy link
Member

@kurotych kurotych commented Dec 4, 2024

Additional feature to previous PR: #902

Add migration to back fill data.
usage
./target/debug/mobile-config -c mobile-config.toml migrate-mobile-tracker file.csv

Migration steps:

  1. Fill mobile_radio_tracker asserted_location from mobile_hotspot_infos
  2. Read data from csv report. Fill mobile_radio_tracker.asserted_location_changed_at if location from csv and in mobile_hotspot_infos table matches

@kurotych kurotych force-pushed the mobile-config-tracker-asserted_at branch from 758bdaf to 02a3651 Compare December 4, 2024 10:26
@kurotych kurotych marked this pull request as ready for review December 4, 2024 11:43
last_changed_at: radio.refreshed_at,
last_checked_at: Utc::now(),
asserted_location: radio.location,
asserted_location_change_at: None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the thinking about making this None? The first time we see a radio, this field will be null and how do you envision clients working with it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the thinking about making this None?

My logic is next: At the beginning it is None because we don't have information about previous time when asserted_location was changed.

The first time we see a radio, this field will be null and how do you envision clients working with it?

I expect clients (or functions that use tracked mobile radio table) will handle None by their own logic.
Otherwise, if we hardcode some value here, we don't give an option for the clients.

@kurotych kurotych requested a review from bbalser December 4, 2024 13:36
@kurotych kurotych marked this pull request as draft February 3, 2025 09:33
@kurotych kurotych force-pushed the mobile-config-tracker-asserted_at branch from abffa28 to aa74962 Compare February 5, 2025 10:19
@kurotych kurotych force-pushed the mobile-config-tracker-asserted_at branch from aa74962 to c611091 Compare February 5, 2025 10:24
@kurotych kurotych marked this pull request as ready for review February 5, 2025 10:46
@kurotych kurotych changed the title Have location tracking in mobile-config track Have location tracking in mobile-config track (OLD) Jun 24, 2025
@kurotych kurotych closed this Jun 24, 2025
@kurotych kurotych deleted the mobile-config-tracker-asserted_at branch November 10, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants