Return error in average_distance and multiplier functions instead of panic
#979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the error handling in two functions to return errors instead of panicking when encountering empty input arrays. The changes ensure that both average_distance and multiplier functions propagate errors, while the calling code in mobile_verifier and in other modules is updated to handle these errors.
- Refactored average_distance and multiplier functions to return Result types.
- Updated error propagation in lib.rs and logging in mobile_verifier.
- Added tests to confirm that empty inputs return errors.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mobile_verifier/src/reward_shares.rs | Updated multiplier usage to handle the Result variant. |
| coverage_point_calculator/src/location.rs | Changed average_distance and multiplier to return Results. |
| coverage_point_calculator/src/lib.rs | Propagated errors using '?' and updated SPBoostedHexStatus. |
kurotych
changed the title
average_distance and multiplier functions instead of panic
kurotych
requested review from
bbalser,
jeffgrunewald,
macpie and
michaeldjeffrey
bbalser
approved these changes
Apr 2, 2025
michaeldjeffrey
approved these changes
Apr 2, 2025
macpie
pushed a commit
that referenced
this pull request
Apr 14, 2025
macpie
pushed a commit
that referenced
this pull request
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return error in
average_distanceandmultiplierfunctions instead of panic