New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab completion #1

Merged
merged 4 commits into from Jun 1, 2017

Conversation

Projects
None yet
2 participants
@adamrk
Contributor

adamrk commented May 29, 2017

No description provided.

adamrk added some commits May 29, 2017

fix bug caused by incomplete pattern in precedence function
typing in a string like "4 + sqrt(5)" would cause a crash
because in the middle of typing "sqrt" the evaluator would
treat 's' as an operator and try to compare it's precedence
to the precedence of '+'. The precedence function did not
match all patterns and this adds an otherwise case.
add tab completion by displaying functions matching prefix
Added a function to State which returns a list of all defined
values/functions matching a prefix. Modify the tab printout to
display 5 of these results.
@hellerve

This comment has been minimized.

Owner

hellerve commented Jun 1, 2017

Looks good to me. Should I take over from here or do you want to keep working on it?

@hellerve hellerve merged commit dad9e71 into hellerve:master Jun 1, 2017

@adamrk

This comment has been minimized.

Contributor

adamrk commented Jun 2, 2017

Either is good for me. What do you think should happen next with it?

@hellerve

This comment has been minimized.

Owner

hellerve commented Jun 2, 2017

I'm not sure, actually. The next thing I will be working on is reverse search.

Maybe tab completion should also complete keywords? I don't actually know whether that's a good idea and whether that should be context-dependent. What do you think?

@adamrk

This comment has been minimized.

Contributor

adamrk commented Jun 4, 2017

Yeah I think adding the keywords would be good. What's reverse search?

@hellerve

This comment has been minimized.

Owner

hellerve commented Jun 5, 2017

It's incremental history search on the command line. Most readline implementations support that through Ctrl+S, and I thought it might be a good idea to add. It's now in the master branch and seems to work fairly well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment